WIP: raylib5 #180
Draft
WIP: raylib5 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating |
|
On mac M1 (Sonoma 14.6.1 (23G93)) I think issue is something in node-raylib.cc. It's a bit hard to tell because it buries the build-error (it seems to select ninja, and I always have that prob with ninja, since I am dyslexic and it strips colors) but I searched for error, and I see these 2: looks like In both cases, it appears to be usage of inline ModelAnimation ModelAnimationFromValue(const Napi::CallbackInfo& info, int index) {
return {
intFromValue(info, index + 0),
intFromValue(info, index + 1),
(BoneInfo *) pointerFromValue(info, index + 2),
(Transform **) pointerFromValue(info, index + 3),
// HERE
pointerFromValue(info, index + 4)
};
}
inline AutomationEvent AutomationEventFromValue(const Napi::CallbackInfo& info, int index) {
return {
unsignedintFromValue(info, index + 0),
unsignedintFromValue(info, index + 1),
// HERE
pointerFromValue(info, index + 2)
};
}In other uses of these, they have type-prefixes (to set what kind of pointer it is) so that might be the prob. These are the 2 type-conversions: // ModelAnimation
typedef struct ModelAnimation {
int boneCount; // Number of bones
int frameCount; // Number of animation frames
BoneInfo *bones; // Bones information (skeleton)
Transform **framePoses; // Poses array by frame
char name[32]; // Animation name
} ModelAnimation;
// Automation event
typedef struct AutomationEvent {
unsigned int frame; // Event frame
unsigned int type; // Event type (AutomationEventType)
int params[4]; // Event parameters (if required)
} AutomationEvent;I tried to manually fix on first one, to try to match it to other calls of inline ModelAnimation ModelAnimationFromValue(const Napi::CallbackInfo& info, int index) {
return {
intFromValue(info, index + 0),
intFromValue(info, index + 1),
(BoneInfo *) pointerFromValue(info, index + 2),
(Transform **) pointerFromValue(info, index + 3),
(char*)pointerFromValue(info, index + 4)
};
}which caused another error: so I am not sure how to resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raylib5 was released. This branch documents the effort to upgrade.
Currently this fails to build. These are missing:
GenImageGradientVGenImageGradientHLoadModelAnimationsDrawLineBezierQuadDrawLineBezierCubic